Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PWA Studio URL redirect not working #4305

Merged
merged 1 commit into from
Aug 8, 2024
Merged

PWA Studio URL redirect not working #4305

merged 1 commit into from
Aug 8, 2024

Conversation

glo11372
Copy link
Contributor

Description

  1. Status changes 301 when redirect happens

Related Issue

Closes #ijra.corp.adobe.com/browse/PWA-3303

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@glo11372 glo11372 requested a review from glo82145 July 30, 2024 05:53
@glo11372 glo11372 self-assigned this Jul 30, 2024
@glo11372 glo11372 added version: Minor This changeset includes functionality added in a backwards compatible manner. pkg:peregrine labels Jul 30, 2024
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Jul 30, 2024 •
edited
Loading

Messages
📖

Associated JIRA tickets: PWA-3303.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against ac362ba

@glo82145
Copy link
Collaborator

glo82145 commented Aug 8, 2024

run pr-test

@pwa-test-bot
Copy link

pwa-test-bot bot commented Aug 8, 2024

Successfully started codebuild job for pr-test

@glo82145 glo82145 merged commit c35e41f into develop Aug 8, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glo82145 glo82145 glo82145 approved these changes

Assignees

@glo82145 glo82145

@glo11372 glo11372

Labels
pkg:peregrine pkg:venia-ui Progress: approved Progress: done version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
Pull Request Progress
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glo11372 @pwa-studio-bot @glo82145